feat #17666: Display icons for component priority#19870
Open
Samuel-k276 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Samuel-k276
force-pushed
the
feat-17666-priority-indicators
branch
from
60b9d0d to
fcec8a9
Compare
- Add 5 new svg (1 for each priority) - Add trumping logic to select the svg based on the component priority - Display the priority along with the remaining icons related to the component - Add a test to validate this logic checking each boundary Closes WeblateOrg#17666 Co-authored-by: Dinis Sales <dinis.sales@tecnico.ulisboa.pt>
Samuel-k276
force-pushed
the
feat-17666-priority-indicators
branch
from
fcec8a9 to
8ee0444
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Video of all this working
Weblate.__.Priority.icon.feature.mp4
Closes #17666